Fix #129104 by adding a FeatureFlag to YAML tests #129569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosdelest
added
>test
carlosdelest
commented
Jun 18, 2025
|
|
||
| protected FullTextFunctionTestCase(Class<? extends FullTextFunction> fullTextFunction) { | ||
| this(fullTextFunction, randomFrom("text", "keyword"), randomAlphaOfLengthBetween(1, 10)); | ||
| this(fullTextFunction, randomFrom("text", "keyword"), randomAlphaOfLengthBetween(5, 10)); |
There was a problem hiding this comment.
Unrelated to this fix, but had a test failure on the CI that I thought was worth fixing. This makes it harder for a query to be repeated, and thus simplified, on the full text function test cases - which can cause failures as the actual query is not the expected one.
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
|
Closes this one too: #129602 |
carlosdelest
added
auto-backport
kderusso
pushed a commit
to kderusso/elasticsearch
that referenced
this pull request
Jun 23, 2025
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jun 25, 2025
carlosdelest
added a commit
to carlosdelest/elasticsearch
that referenced
this pull request
Jul 30, 2025
carlosdelest
added a commit
that referenced
this pull request
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #129104
Closes #129602
Release tests don't have feature flags active. There were a couple
ESClientYamlSuiteTestCasethatdidn't have theIVF_FORMATfeature flag, and thus failed release tests when YAML tests tried to createbbq_ivfindex formats.